-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a plugin preview using playground #664
Enable a plugin preview using playground #664
Conversation
[pull] main from GatherPress:main
Am I right that the existing |
Try to remove the need for the action, by using github-proxy.com seems to be not straight forward.
Internally $url = "https://github.com/$repo/releases/download/$release/$asset"; which works fine with numbered, but not the latest release. Acording to download - Is there a link to GitHub for downloading a file in the latest release of a repository? - Stack Overflow the url template needs some change. $url = "https://github.com/$repo/releases/download/$release/$asset"; |
Hello @mauteri , I would call this almost ready ... except some questions. I would like to read your opinions on one or the other. Or all ;)
|
Because this That's what I did in my last commit and mentioned first time in #663 (comment). |
NOTE: Can be merged after Export & Import PR is merged. |
@carstingaxion now that Export/Import PR has been merged are we now able to merge this PR? |
I think so, yes @mauteri . I had a look at the blueprint.json again, which looks good to me. But there is no risk, with that, because the plugin preview on w.org is hidden behind a feature flag, that only you (as plugin author) can enable. So you (and others, if you share the link) can test that, before going live. |
Description of the Change
Closes #
How to test the Change
blueprint.json
file/events/
with an image showing the Events List block in the block-inserter and a heading:Changelog Entry
Credits
Props @carstingaxion
Checklist:
I have added tests to cover my change.