-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW block variation "Add to calendar" #954
Merged
mauteri
merged 15 commits into
GatherPress:develop
from
carstingaxion:feature/blockvariation-add-to-calendar
Oct 22, 2024
Merged
NEW block variation "Add to calendar" #954
mauteri
merged 15 commits into
GatherPress:develop
from
carstingaxion:feature/blockvariation-add-to-calendar
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview changes with PlaygroundYou can preview the recent changes for PR#954 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bildschirmaufzeichnung.vom.18.10.2024.14.10.24.mp4
Closes #606
How to test the Change
Known Issue: ical & outlook have no
href
attribute.I guess that WordPress added some escaping to the sources bound to the
url
attribute of a button.Because, when I make a debug-change and direct the Block Binding API to output the values into the
text
attribute, instead ofurl
, one can see that the URLs are properly delivered into the block.I think the ical data-uri might just fail against
esc_url()
or something similar.I would not recommend trying to fix this or to do any changes to this PR, but instead move #928 forward!
#928 and another, yet unfinished necessary follow-up (to fully align with #831) will introduce new named endoints like
https://example.org/event/test-event-954/ical
, which will make the escaping pass and the blocks work like expected.Changelog Entry
Credits
Props @carstingaxion
Checklist: