Adding test-case for the data.py #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevenDuverglas
added
test
KevenDuverglas
requested review from
gkapfham,
jnormile,
AidanNeeson and
hayleepierce
and removed request for
AidanNeeson
KevenDuverglas
changed the title
hayleepierce
approved these changes
Dec 5, 2023
jnormile
approved these changes
Dec 5, 2023
rodriguez03
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a pull request to add a new feature or alter an existing one,
there are some important elements to include to help our team review and process it more efficiently.
Make sure the title is descriptive of what the PR includes. Don't mention issue names/numbers; save that for the description.
List the names of those who contributed to the project.
Keven Duverglas
Link the issue the pull request is meant to fix/resolve.
Write Tests for All Existing Features #12
Add all labels that apply. (e.g. documentation, ready-for-review)
Did it
Describe the contents and goal of the pull request.
To improve test coverage and to test the features of data.py
Will coverge be maintained/increased?
I believe the test coverage will be increased.
What operating systems has this been tested on? How were these tests conducted?
Unbuntu, these tests were conducted using pytest
Include a code block and/or screenshots displaying the functionality of your feature, if applicable/possible.
Mark as a draft until it is ready to begin the reviewing process, then tag our Lead Software Architect,
Jeff Normile, our Founding Engineer, Gregory Kapfhammer,
and our Project Managers, Haylee Pierce and Sabrina Rodriguez
when you mark it as ready for review.