Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mapWig & repTimeWig to be optional #15

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ycl6
Copy link

@ycl6 ycl6 commented Sep 20, 2023

This PR make changes to the run_ichorCNA and wigToGRanges functions, so that users can skip supplying the two optional wig params (mapWig and repTimeWig) when running ichorCNA.

Error in wigToGRanges(mapWig) : 
  argument "mapWig" is missing, with no default
In addition: Warning message:
In message("wigToGRanges: WIG file '", wigfile, "' not found.") :
  restarting interrupted promise evaluation
Error in wigToGRanges(repTimeWig) : 
  argument "repTimeWig" is missing, with no default
In addition: Warning message:
In message("wigToGRanges: WIG file '", wigfile, "' not found.") :
  restarting interrupted promise evaluation

I also added checks to make sure the two required params tumor_wig and gcWig are provided by users and improved the error messaging.

Previously:

Error in substr(tumor_wig, nchar(tumor_wig) - 2, nchar(tumor_wig)) : 
  argument "tumor_wig" is missing, with no default
Reading GC and mappability files
Error in wigToGRanges(gcWig) : 
  argument "gcWig" is missing, with no default
In addition: Warning message:
In message("wigToGRanges: WIG file '", wigfile, "' not found.") :
  restarting interrupted promise evaluation

Now

Error in run_ichorCNA(id = "test", ...
  tumor wig file not provided but is required
Error in run_ichorCNA(id = "test", ...
  GC wig file not provided but is required

@gavinha gavinha merged commit ea4814f into GavinHaLab:master Oct 5, 2023
@istvankleijn istvankleijn mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants