Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Downloader to use linear-ish types, replace ArtifactPaths struct with ModArtifact helpers, and add reusable artifact FS interaction logic #141

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Refactor Downloader to use linear-ish types, replace ArtifactPaths struct with ModArtifact helpers, and add reusable artifact FS interaction logic #141

merged 7 commits into from
Jan 23, 2024

Conversation

Gawdl3y
Copy link
Owner

@Gawdl3y Gawdl3y commented Jan 23, 2024 •
edited
Loading

  • Refactors the Downloader functionality to take advantage of linear-like types
  • Removes ArtifactPaths and replaces its functionality with dest_within, tmp_dest, and old_dest on ModArtifact
  • Introduces additional logging for any failed cancelled/undone downloads
  • Extracts common artifact FS interactions into reusable functions
  • Ensures all errors from the downloader are ArtifactErrors

@Gawdl3y Gawdl3y added the other Doesn't quite fit into other labels label Jan 23, 2024
@Gawdl3y Gawdl3y force-pushed the clean/downloader-artifactpaths-refactor branch from 449d8a2 to 2f06ae0 Compare January 23, 2024 04:32
@Gawdl3y Gawdl3y changed the title Refactor Downloader to use linear-ish types & replace ArtifactPaths struct with ModArtifact helpers Refactor Downloader to use linear-ish types, replace ArtifactPaths struct with ModArtifact helpers, and add reusable Artifact FS interaction logic Jan 23, 2024
@Gawdl3y Gawdl3y changed the title Refactor Downloader to use linear-ish types, replace ArtifactPaths struct with ModArtifact helpers, and add reusable Artifact FS interaction logic Refactor Downloader to use linear-ish types, replace ArtifactPaths struct with ModArtifact helpers, and add reusable artifact FS interaction logic Jan 23, 2024
@Gawdl3y Gawdl3y merged commit 1d1c16e into main Jan 23, 2024
6 checks passed
@Gawdl3y Gawdl3y deleted the clean/downloader-artifactpaths-refactor branch January 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
other Doesn't quite fit into other labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gawdl3y