Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out internal dissipation as external addon dissipation module #112

Closed
bhosale2 opened this issue Jun 14, 2022 · 1 comment · Fixed by #114
Closed

Factor out internal dissipation as external addon dissipation module #112

bhosale2 opened this issue Jun 14, 2022 · 1 comment · Fixed by #114
Assignees
Labels
enhancement New feature or request update Update the codebase
Milestone

Comments

@bhosale2
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, the internal dissipation used to stabilize PyElastica simulations is a part of the Cosserat rod governing equations. This leads to the following 2 issues:

  1. In over/critically damped cases, this can lead to a severe limitation on the timestep size, slowing down simulations.
  2. Does not allow for a cleaner way to simulate an undamped rod, other than setting nu = 0 and crunching the damping steps for no reason.

Describe the solution you'd like
Following discussion with @armantekinalp, the dissipation step can be factored out of the Cosserat rod equations, and treated analytically, resulting in an exponential damper dissipation module, which is

  1. Cleaner add-on module to undamped Cosserat rod.
  2. Imposes no timestep restrictions on the simulator.
  3. Allows for cleaner testing for other dissipation schemes (like filtering)
@bhosale2 bhosale2 added enhancement New feature or request update Update the codebase labels Jun 14, 2022
@bhosale2 bhosale2 added this to the Version 0.2.4 milestone Jun 14, 2022
@bhosale2 bhosale2 linked a pull request Jun 16, 2022 that will close this issue
16 tasks
@bhosale2 bhosale2 modified the milestones: Version 0.2.4, Version 0.3 Jun 17, 2022
@bhosale2
Copy link
Collaborator Author

Closed via #114.

pppprub pushed a commit to pppprub/PyElastica that referenced this issue Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request update Update the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants