Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate joint module into separate connections and collision #113

Closed
bhosale2 opened this issue Jun 16, 2022 · 12 comments
Closed

Separate joint module into separate connections and collision #113

bhosale2 opened this issue Jun 16, 2022 · 12 comments
Assignees
Labels
discussion Topic that needs to be discussed. enhancement New feature or request prio:low Priority level: low
Milestone

Comments

@bhosale2
Copy link
Collaborator

Currently, the implementation for connections and collision lies in joint.py which is a rather non-intuitive name for its contents. A more intuitive name could be connections_and_collision.py? @armantekinalp and @skim0119 suggestions?

@bhosale2 bhosale2 added enhancement New feature or request discussion Topic that needs to be discussed. labels Jun 16, 2022
@bhosale2 bhosale2 added this to the Version 0.2.4 milestone Jun 16, 2022
@skim0119
Copy link
Collaborator

I think collision should be separated. I agree that `connection could be more general name.

@skim0119 skim0119 added the good first issue Good for newcomers label Jun 17, 2022
@bhosale2
Copy link
Collaborator Author

Ok, then the consensus on this is:

  1. Rename joint.py to connections.py
  2. Move out collision classes into a separate collision.py

@armantekinalp
Copy link
Contributor

Yes, I think it is a good idea

@bhosale2 bhosale2 modified the milestones: Version 0.2.4, Version 0.3 Jun 18, 2022
@bhosale2 bhosale2 self-assigned this Jun 18, 2022
@bhosale2 bhosale2 changed the title Rename joint.py to have a more intuitive name Separate joint module into separate connections and collision Jul 21, 2022
@bhosale2 bhosale2 added prio:low Priority level: low and removed good first issue Good for newcomers labels Jul 29, 2022
@bhosale2 bhosale2 modified the milestones: Version 0.3, Version 0.3.1 Aug 1, 2022
@bhosale2 bhosale2 assigned Ali-7800 and unassigned bhosale2 Jun 12, 2023
@Ali-7800
Copy link
Collaborator

Ali-7800 commented Jul 17, 2023

Merging checklist

  • New contact module, Surface base class and tests
  • Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests
  • Surface subclass: plane, and tests
  • Updated rod-plane contact classes (from InteractionPlane and AnistropicFrictionalPlane)
  • Updated rod-plane contact classes tests and refactor contact functions in interaction.py and joint.py
  • Updated rod-plane contact examples
  • Cylinder-plane contact class and tests
  • Contact Module Documentation (Contact Module Documentation #331)

@Rahul-JOON
Copy link
Contributor

@Ali-7800 added the New Contact module, surface base class, and tests via #281.

@Ali-7800
Copy link
Collaborator

Added Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests via #291

@Ali-7800
Copy link
Collaborator

Added the new plane surface subclass.

@Ali-7800
Copy link
Collaborator

Added updated rod-plane contact class

@Ali-7800
Copy link
Collaborator

Ali-7800 commented Nov 7, 2023

Updated rod-plane contact classes tests and refactored contact functions in interaction.py and joint.py

@Ali-7800
Copy link
Collaborator

Ali-7800 commented Dec 6, 2023

Updated rod-plane contact examples and added continuum snake with lifting wave example

@Ali-7800
Copy link
Collaborator

Added cylinder-plane contact class

@Ali-7800
Copy link
Collaborator

Updated documentation for contact module, closing now as issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topic that needs to be discussed. enhancement New feature or request prio:low Priority level: low
Projects
None yet
Development

No branches or pull requests

5 participants