-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests #291
Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests #291
Conversation
@Ali-7800 can you also share the plots or videos for the all examples you have changed in this PR as future reference. Thanks. |
Plectonemes Case: 2D_xy_plectonemes.mp42D_xz_plectonemes.mp42D_zy_plectonemes.mp43D_plectonemes.mp4Solenoids Case: 2D_xy_solenoid.mp42D_xz_solenoid.mp42D_zy_solenoid.mp43D_solenoid.mp4rod_rod_contact_inclined_validation: 2D_xy_inclined_rods_contact.mp42D_xz_inclined_rods_contact.mp42D_zy_inclined_rods_contact.mp43D_inclined_rods_contact.mp4rod_rod_contact_parallel_validation: 2D_xy_parallel_rods_contact.mp42D_xz_parallel_rods_contact.mp42D_zy_parallel_rods_contact.mp43D_parallel_rods_contact.mp4Rod Cylinder Parallel Contact: 2D_xy_rod_cylinder_contact.mp42D_xz_rod_cylinder_contact.mp42D_zy_rod_cylinder_contact.mp43D_rod_cylinder_contact.mp4Rod Cylinder Inclined Contact: 2D_xy_rod_cylinder_contact.mp42D_xz_rod_cylinder_contact.mp42D_zy_rod_cylinder_contact.mp43D_rod_cylinder_contact.mp4Rod Cylinder Contact with y normal: 2D_cylinder_rod_collision.mp4cylinder_rod_collision.mp4Rod Cylinder Contact validation: 2D_cylinder_rod_collision.mp4cylinder_rod_collision.mp4Rod Cylinder Contact Friction: 2D_xy_rod_cylinder_contact.mp42D_xz_rod_cylinder_contact.mp42D_zy_rod_cylinder_contact.mp43D_rod_cylinder_contact.mp4Rod Cylinder Contact Friction Phase Space: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes.
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #291 +/- ##
================================================
- Coverage 93.71% 93.01% -0.71%
================================================
Files 48 49 +1
Lines 3055 3334 +279
Branches 354 392 +38
================================================
+ Hits 2863 3101 +238
- Misses 155 181 +26
- Partials 37 52 +15
☔ View full report in Codecov by Sentry. |
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
@Ali-7800 can you also check why coverage is going down by 6%? |
it's because I changed the contact tests from using |
…nce ExternalContact and SelfContact and removed from joint
Added old tests back to in test_contact_specfic_functions.py, test_contact_common_functions.py, and test_contact_wrapper_classes.py so coverage does not go down. Should be removed later with ExternalContact and SelfContact in joint.py |
Added warning message to ExternalContact and SelfContact in joint.py about deprecation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM two minor suggestions
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Otherwise, LGTM
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
Second contact module PR mentioned in Issue
This PR includes: