Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update timestep values for the new damping module #120

Conversation

bhosale2
Copy link
Collaborator

@bhosale2 bhosale2 commented Jun 27, 2022

Fixes #118.

The example timestep values will be investigated (with help from @armantekinalp), along with confirmation, that the dynamics of the individual cases stay the same:

  • axial stretching - 10x larger timestep, with 10x smaller damping constant
  • binder stuff - for snake 12.5x larger timestep, with same damping constant, no change for timoshenko
  • butterfly
  • continuum flagella - 4x larger timestep, with 4x smaller damping constant
  • continuum snake - 12.5x larger timestep, with same damping constant
  • Experimental cases - parallel connection - 100x larger timestep, with 10x smaller damping constant
  • flexible swinging pendulum
  • friction validation cases - 2 times larger time-step, 2 times smaller damping constant
  • helical buckling - No improvement.
  • joint cases - 5-10x larger timestep, with same damping constant
  • muscular flagella - No change. For larger timesteps, it is unstable with the same damping constant
  • muscular snake - No change. For larger timesteps, it is unstable with the same damping constant
  • restart example
  • rod-rod contact cases - 5-10x larger timestep, with 5-10x smaller damping constant
  • rod self contact cases - No improvement
  • timoshenko - 7x larger tilmestep, with 7x smaller damping constant

@bhosale2 bhosale2 added the enhancement New feature or request label Jun 27, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jun 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #120 (6e00f63) into update-0.3.0 (3a4963c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           update-0.3.0     #120      +/-   ##
================================================
+ Coverage         87.32%   87.41%   +0.09%     
================================================
  Files                44       44              
  Lines              2619     2639      +20     
  Branches            353      355       +2     
================================================
+ Hits               2287     2307      +20     
  Misses              310      310              
  Partials             22       22              
Impacted Files Coverage Δ
elastica/rod/factory_function.py 97.69% <100.00%> (ø)
elastica/typing.py 100.00% <0.00%> (ø)
elastica/dissipation.py 95.45% <0.00%> (+3.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2008f29...6e00f63. Read the comment docs.

armantekinalp and others added 4 commits June 26, 2022 23:06
We remove nu from the initialization of snake muscular rods.
We remove nu from the initialization of flagella muscular rods.
@bhosale2 bhosale2 marked this pull request as ready for review July 5, 2022 19:41
@bhosale2 bhosale2 requested a review from armantekinalp as a code owner July 5, 2022 19:41
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge, I am excited to see improvements with LaplaceDissipationFilter next.

@bhosale2 bhosale2 merged commit d3d7201 into GazzolaLab:update-0.3.0 Jul 6, 2022
@bhosale2 bhosale2 deleted the 118_update_timestep_for_new_damping_module branch July 6, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit timestep limits for example cases after damping module change (#114)
3 participants