-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update timestep values for the new damping module #120
[WIP] Update timestep values for the new damping module #120
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.3.0 #120 +/- ##
================================================
+ Coverage 87.32% 87.41% +0.09%
================================================
Files 44 44
Lines 2619 2639 +20
Branches 353 355 +2
================================================
+ Hits 2287 2307 +20
Misses 310 310
Partials 22 22
Continue to review full report at Codecov.
|
Time step for timoshenko increased by 7 times.
…github.com/bhosale2/PyElastica into 118_update_timestep_for_new_damping_module
We remove nu from the initialization of snake muscular rods.
We remove nu from the initialization of flagella muscular rods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can merge, I am excited to see improvements with LaplaceDissipationFilter next.
Fixes #118.
The example timestep values will be investigated (with help from @armantekinalp), along with confirmation, that the dynamics of the individual cases stay the same:
butterflyflexible swinging pendulumrestart example