New feature: ring Cosserat rods #229
Conversation
armantekinalp
added
enhancement
and shear modulus since they are not used anymore
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## update-0.3.1 #229 +/- ##
================================================
+ Coverage 87.45% 87.93% +0.48%
================================================
Files 41 43 +2
Lines 2798 3067 +269
Branches 320 354 +34
================================================
+ Hits 2447 2697 +250
- Misses 330 341 +11
- Partials 21 29 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ring rod. It will be run after memory block is constructed
removed, since it is not used.
|
@ilianasiriziba Can you put the videos of ring rod under gravity simulation here. |
2D_xy_ring_rod.mp42D_xz_ring_rod.mp42D_zy_ring_rod.mp4 |
export PATH="$HOME/.poetry/bin:$PATH"
|
I'll start the review. |
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
|
@bhosale2 please start reviewing. |
There was a problem hiding this comment.
Some work and doubts @armantekinalp. @ilianasiriziba can help out here.
|
@bhosale2 I have updated documentation please check and see if it make sense. |
There was a problem hiding this comment.
LGTM. @armantekinalp and @ilianasiriziba thanks for all the clarifications and adding this new feature.
Ring Cosserat rods will be added with this PR. Ring rods requires a periodic boundary condition at their ends to simulate the effect of closed loop. In order to implement this periodic boundary condition, in backend we modified the memory block and included two additional nodes, elements and voronoi. Position, directors, velocity and omega of these boundary nodes are synched after every kinematic update.