Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing testing arguments #269

Merged

Conversation

Rahul-JOON
Copy link
Contributor

Previously the assert cases were comparing the forces with themselves and not to a copy array before execution; this PR has fixed it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (16b5bc4) 94.72% compared to head (8273aeb) 94.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff              @@
##           update-0.3.2     #269   +/-   ##
=============================================
  Coverage         94.72%   94.72%           
=============================================
  Files                43       43           
  Lines              2938     2938           
  Branches            341      341           
=============================================
  Hits               2783     2783           
  Misses              122      122           
  Partials             33       33           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rahul-JOON Rahul-JOON marked this pull request as ready for review June 15, 2023 07:19
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rahul-JOON

Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit 541a48f into GazzolaLab:update-0.3.2 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants