Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh Methods + last attribute #277

Merged

Conversation

Rahul-JOON
Copy link
Contributor

@Rahul-JOON Rahul-JOON commented Jul 14, 2023

This PR adds the remaining methods and attributes necessary for mesh initialization mentioned in #270, namely:

Attributes:
1. Orientation

Methods:
1. Visualize
2. Translate
3. Scale
4. Rotate
5. Update

@Rahul-JOON Rahul-JOON marked this pull request as ready for review July 14, 2023 16:44
@bhosale2 bhosale2 requested a review from Ali-7800 July 14, 2023 17:18
@bhosale2 bhosale2 added enhancement New feature or request prio:high Priority level: high labels Jul 14, 2023
@bhosale2 bhosale2 added this to the Version 0.3.2 milestone Jul 14, 2023
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff

mesh/mesh_initializer.py Outdated Show resolved Hide resolved
mesh/mesh_initializer.py Outdated Show resolved Hide resolved
mesh/mesh_initializer.py Outdated Show resolved Hide resolved
mesh/mesh_initializer.py Outdated Show resolved Hide resolved
tests/test_mesh_methods.py Show resolved Hide resolved
mesh/mesh_initializer.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.02 🎉

Comparison is base (58610f7) 93.56% compared to head (081d75c) 93.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #277      +/-   ##
================================================
+ Coverage         93.56%   93.59%   +0.02%     
================================================
  Files                43       44       +1     
  Lines              2938     2998      +60     
  Branches            341      347       +6     
================================================
+ Hits               2749     2806      +57     
- Misses              152      155       +3     
  Partials             37       37              
Impacted Files Coverage Δ
elastica/mesh/mesh_initializer.py 95.00% <95.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Ali-7800 Ali-7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rahul-JOON Rahul-JOON requested a review from skim0119 as a code owner July 18, 2023 01:32
@armantekinalp armantekinalp removed the request for review from skim0119 July 18, 2023 03:30
@bhosale2 bhosale2 self-requested a review July 21, 2023 04:04
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp armantekinalp merged commit 3c4a8d5 into GazzolaLab:update-0.3.2 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio:high Priority level: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants