Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBJ Functioning #283

Merged
merged 6 commits into from
Jul 31, 2023
Merged

OBJ Functioning #283

merged 6 commits into from
Jul 31, 2023

Conversation

Rahul-JOON
Copy link
Contributor

This PR aims to add .obj file format functioning to the mesh object class in #270.

@Rahul-JOON Rahul-JOON marked this pull request as ready for review July 24, 2023 18:36
@bhosale2 bhosale2 added enhancement New feature or request prio:low Priority level: low prio:high Priority level: high and removed prio:low Priority level: low labels Jul 24, 2023
@bhosale2 bhosale2 added this to the Version 0.3.2 milestone Jul 24, 2023
Ali-7800
Ali-7800 requested changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@Ali-7800 Ali-7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo, otherwise LGTM

elastica/mesh/mesh_initializer.py Outdated Show resolved Hide resolved
armantekinalp
armantekinalp approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elastica/mesh/mesh_initializer.py Outdated Show resolved Hide resolved
@armantekinalp armantekinalp removed the request for review from skim0119 July 30, 2023 15:51
Rahul-JOON and others added 3 commits July 30, 2023 22:52
@Rahul-JOON @armantekinalp
typo
25b9d7d 
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
@Rahul-JOON
Revert "typo"
61292f9 
This reverts commit 25b9d7d.
@Rahul-JOON
typo
f8087d1
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c4a8d5) 93.59% compared to head (f8087d1) 93.60%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@              Coverage Diff              @@
##           update-0.3.2     #283   +/-   ##
=============================================
  Coverage         93.59%   93.60%           
=============================================
  Files                44       44           
  Lines              2998     3000    +2     
  Branches            347      347           
=============================================
+ Hits               2806     2808    +2     
  Misses              155      155           
  Partials             37       37
Files Changed Coverage Δ
elastica/mesh/mesh_initializer.py 95.16% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhosale2 bhosale2 requested a review from Ali-7800 July 31, 2023 02:27
Ali-7800
Ali-7800 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Ali-7800 Ali-7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhosale2
bhosale2 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit 7c6a2a3 into GazzolaLab:update-0.3.2 Jul 31, 2023
@Rahul-JOON Rahul-JOON deleted the 270_Mesh_Object_Class branch August 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@Ali-7800 Ali-7800 Ali-7800 approved these changes

@bhosale2 bhosale2 bhosale2 approved these changes

Assignees

@Rahul-JOON Rahul-JOON

Labels
enhancement New feature or request prio:high Priority level: high
Projects
None yet
Milestone
Version 0.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Rahul-JOON @codecov-commenter @bhosale2 @Ali-7800 @armantekinalp