Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing/memory block #384

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Typing/memory block #384

merged 9 commits into from
Jun 13, 2024

Conversation

armantekinalp
Copy link
Contributor

Typing for rod and rigid body memory blocks.

@armantekinalp armantekinalp self-assigned this May 13, 2024
@armantekinalp armantekinalp marked this pull request as draft May 13, 2024 19:41
@armantekinalp armantekinalp marked this pull request as ready for review May 14, 2024 21:47
armantekinalp and others added 3 commits May 14, 2024 19:56
@skim0119
Copy link
Collaborator

Does it pass if you run poetry run mypy --config-file pyproject.toml elastica/memory_block?

@armantekinalp
Copy link
Contributor Author

Does it pass if you run poetry run mypy --config-file pyproject.toml elastica/memory_block?

It doesn't because SystemIdxType is not defined. You have defined in PR #382 . We can wait you to merge that.

@skim0119
Copy link
Collaborator

skim0119 commented May 15, 2024 •
edited
Loading

SystemIdxType is now included in update/mypy branch: https://github.com/GazzolaLab/PyElastica/blob/update/mypy/elastica/typing.py

PyElastica/elastica/typing.py

Line 58 in 4d05804

SystemIdxType: TypeAlias = int

@armantekinalp
Copy link
Contributor Author

Cool thanks, now it passes

@skim0119
Copy link
Collaborator

On this PR, can you also include typing for the file elastica/modules/memory_block.py?

@armantekinalp
Copy link
Contributor Author

okay will work on that

@skim0119
Copy link
Collaborator

Also this one: https://github.com/armantekinalp/PyElastica/blob/typing/memory_block/elastica/reset_functions_for_block_structure/_reset_ghost_vector_or_scalar.py

@armantekinalp armantekinalp marked this pull request as draft May 15, 2024 18:52
@skim0119 skim0119 marked this pull request as ready for review June 13, 2024 12:47
skim0119
skim0119 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 1e38e3a into GazzolaLab:update/mypy Jun 13, 2024
2 of 6 checks passed
@skim0119
Copy link
Collaborator

Also this one: https://github.com/armantekinalp/PyElastica/blob/typing/memory_block/elastica/reset_functions_for_block_structure/_reset_ghost_vector_or_scalar.py

On this PR, can you also include typing for the file elastica/modules/memory_block.py?

@armantekinalp I accidently resolved them on 384

@skim0119 skim0119 mentioned this pull request Jun 13, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

@bhosale2 bhosale2 Awaiting requested review from bhosale2

Assignees

@armantekinalp armantekinalp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armantekinalp @skim0119