Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch: Clean up for update 0.3.0 #76

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Patch: Clean up for update 0.3.0 #76

merged 4 commits into from
Apr 28, 2022

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Apr 28, 2022 •
edited
Loading

Changes

I made changes before, and I want to clean the branch on my local 😄

  • Removed deprecated files for 0.3.0
    • Deprecation warning for _elastica_numba
    • Deprecation error for _elastica_numpy

@skim0119 skim0119 added the enhancement New feature or request label Apr 28, 2022
@skim0119 skim0119 added this to the Version 0.3 milestone Apr 28, 2022
@skim0119 skim0119 requested a review from armantekinalp April 28, 2022 03:06
@skim0119 skim0119 self-assigned this Apr 28, 2022
armantekinalp
armantekinalp approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 65df0a0 into GazzolaLab:update-0.3.0 Apr 28, 2022
@skim0119 skim0119 deleted the patch_clean_up branch April 28, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@skim0119 skim0119

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@skim0119 @armantekinalp