Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacken example files (#83) #84

Merged
merged 2 commits into from
May 16, 2022

Conversation

bhosale2
Copy link
Collaborator

@armantekinalp as per discussion, this PR provides blacken option for examples.

@bhosale2 bhosale2 added the enhancement New feature or request label May 16, 2022
@bhosale2 bhosale2 self-assigned this May 16, 2022
@bhosale2 bhosale2 requested a review from armantekinalp May 16, 2022 02:20
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp armantekinalp merged commit 074769a into GazzolaLab:update-0.2.3 May 16, 2022
@bhosale2 bhosale2 deleted the update-0.2.3 branch May 16, 2022 04:08
pppprub pushed a commit to pppprub/PyElastica that referenced this pull request Sep 4, 2022
## Changes

* Rigid Body:
  * Rigid sphere and cylinder test cases
    * New test cases to test rotational and translational
  * Remove internal forces and torques in rigid body: not used
motion of rigid cylinder and sphere.
* Update gitignore for zip and csv file formats

## Enhancement
* Linalg numba faster functions for block structure.
* Factory function updated for new block structure.
* New wrapper to call memory block added
* Time-stepper interfaces are changed for block-structure implementation.
* Block-structure functions for Cosserat rod and reset ghosts.
* Memory block for the rigid body imp
* Memory block validity test cases added
* Governing equation tests for block structure

## Fix
* Rod intialization test fixed
* Stepper interface tests fixed for block structure
* Time-stepper analytic solution tests fixed
  * This commit fixes time-stepper tests using Harmonic oscillator test
cases for block structure implementation.
* Fix a bug in torque calculation. Transport term Jwxw was missing and with this commit we are adding this term.
* Fix: interaction routines for rigid body
* Fix: contact with rigid body
  * Due to the new implementation of rigid body block structure, radius and length are now are 1d arrays with 1 element, Before, they were scalar. This commit fixes the shape problems because of the array implementation.

## Note
This commit is the final version of rigid body block-structure implementation.
Issues and errors are fixed and code is tested.

## Order
Resolve GazzolaLab#9 

Co-authored-by: armantekinalp <armant2@illinois.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants