Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing value in DNA PTB Ionization Structure; missing GetMaterial() in DNA PTB Excitation and Elastic models; #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjpietrzak
Copy link

I have found out that there is one value missing for nitrogen in G4DNAPTBIonisationStructure.cc. I'm the original author of this piece of code (http://dx.doi.org/10.1016/j.ejmp.2022.09.003). The corresponding cross-sections for that energy shell are present in "G4EMLOW8.*/dna" dataset since version 8.2, so no further corrections are needed.

Additionally, I have found a bug repeated twice in G4DNAPTBElasticModel and in G4DNAPTBExcitationModel in their respective SampleSecondaries() methods. Namely, a missing GetMaterial() method resulted in the wrong value of the materialID variable. I found the solution in the G4DNAPTBIonizationModel, where materialID is retrieved correctly.

…ExcitationModel.cc in their respective SampleSecondaries() methods; missing value for nitrogen in G4DNAPTBIonisationStructure.cc
@civanch
Copy link

civanch commented Oct 30, 2024

@sincerti , should Hoang be registered in github? The fix seems to be simple, I can do that after ref09 or you or Hoang can integrate the fix.

@sincerti
Copy link

sincerti commented Oct 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants