missing value in DNA PTB Ionization Structure; missing GetMaterial() in DNA PTB Excitation and Elastic models; #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found out that there is one value missing for nitrogen in G4DNAPTBIonisationStructure.cc. I'm the original author of this piece of code (http://dx.doi.org/10.1016/j.ejmp.2022.09.003). The corresponding cross-sections for that energy shell are present in "G4EMLOW8.*/dna" dataset since version 8.2, so no further corrections are needed.
Additionally, I have found a bug repeated twice in G4DNAPTBElasticModel and in G4DNAPTBExcitationModel in their respective SampleSecondaries() methods. Namely, a missing GetMaterial() method resulted in the wrong value of the materialID variable. I found the solution in the G4DNAPTBIonizationModel, where materialID is retrieved correctly.