Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radiobutton focused state #7

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

rdbende
Copy link

@rdbende rdbende commented Dec 22, 2022

Currently the radiobutton is quite glitchy when focused. Mostly because of the changes introduced in e34864a.

Sometimes they don't render at all:
image

While printing a bunch of errors.

(wish:52092): Gdk-CRITICAL **: 23:05:05.778: IA__gdk_pixbuf_get_from_drawable: assertion 'src_x + width <= src_width && src_y + height <= src_height' failed

** (wish:52092): CRITICAL **: 23:05:05.778: gdk_pixbuf_xlib_render_to_drawable: assertion 'pixbuf != NULL' failed

(wish:52092): GLib-GObject-CRITICAL **: 23:05:05.778: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

and with some Gtk themes it looks like this:
image

This patch fixes these bugs. I removed the focus padding stuff, and copied most parts of the checkbutton code, which works well.

image
image

@Geballin Geballin merged commit a3b14e6 into Geballin:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants