Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed broken check #616

Merged
merged 3 commits into from
Oct 2, 2022
Merged

removed broken check #616

merged 3 commits into from
Oct 2, 2022

Conversation

Freshrojek
Copy link
Contributor

Description

Removed broken check - which currently is blocking a user from logging in.

Related Issue

resolves #392

Motivation and Context

This PR removes the check which confirms the user has paid before logging in, resolving a blocker for MVP.

How Has This Been Tested?

via confirming tests work and manually testing through running the project and logging in.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Freshrojek Freshrojek requested a review from a team as a code owner October 2, 2022 13:16
@Freshrojek Freshrojek requested a review from jamesgeddes October 2, 2022 13:16
@SamWinterhalder
Copy link
Contributor

@Freshrojek I think you are going to need to rebase

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Freshrojek
Copy link
Contributor Author

@Freshrojek I think you are going to need to rebase

Thanks, should be alright now 🤞🏼

@SamWinterhalder SamWinterhalder enabled auto-merge (rebase) October 2, 2022 13:27
@SamWinterhalder SamWinterhalder enabled auto-merge (rebase) October 2, 2022 13:31
@Freshrojek Freshrojek merged commit 1a3a4f2 into main Oct 2, 2022
@Freshrojek Freshrojek deleted the BUG-392-Incorrect-stripe-handoff- branch October 2, 2022 16:31
@jamesgeddes jamesgeddes mentioned this pull request Dec 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWinterhalder SamWinterhalder SamWinterhalder approved these changes

@jamesgeddes jamesgeddes Awaiting requested review from jamesgeddes jamesgeddes is a code owner automatically assigned from GeekZoneHQ/q

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect stripe handoff
2 participants
@Freshrojek @SamWinterhalder