Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Pages for Article and Staticpages javascript is crashing #1049

Closed
eSilverStrike opened this issue Mar 26, 2020 · 1 comment
Closed

Print Pages for Article and Staticpages javascript is crashing #1049

eSilverStrike opened this issue Mar 26, 2020 · 1 comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone
2.2.1sr1

Comments

@eSilverStrike
Copy link
Member

Looks like because some cookie consent javascript is missing
@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Mar 26, 2020
@eSilverStrike eSilverStrike added this to the 2.2.1sr1 milestone Mar 26, 2020
eSilverStrike added a commit that referenced this issue Mar 26, 2020
@eSilverStrike
Fixed Print Pages for Articles and Staticpages javascript crashing issue
ed0507b 
Fix for issue #1049

Had to add cookie consent stuff from COM_createHTMLDocument and also include plg_footercode.

With staticpage also added plg_headercode (along with plg_footercode) and removed title from displaying if page is not surrounded by block
@eSilverStrike
Copy link
Member Author

Had to add cookie consent stuff from COM_createHTMLDocument and also include plg_footercode.

With staticpage also added plg_headercode (along with plg_footercode) and removed title from displaying if page is not surrounded by block.

This way if autotags from other plugins included with page it's css and javascript is also added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Milestone
2.2.1sr1
Development

No branches or pull requests
1 participant
@eSilverStrike