Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When URL Routing Enabled there are Undeclared variables when Viewing Full Article and Print #1058

Closed
eSilverStrike opened this issue Apr 6, 2020 · 1 comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Milestone

Comments

@eSilverStrike
Copy link
Member

This is related to the issue #945

Not sure how I missed not fixing this when I worked on #945 but some global variable declarations where missing which can cause the article page to not display correctly or error out.

This is a scope issue since the router in index.php loads lib-common.php and not article.php

@eSilverStrike eSilverStrike added the Bug An issue describing unexpected or malicious behaviour. label Apr 6, 2020
@eSilverStrike eSilverStrike added this to the 2.2.1sr1 milestone Apr 6, 2020
eSilverStrike added a commit that referenced this issue Apr 6, 2020
Fix for #1058

Also tidied up code and add some code comments a bit for Links and Staticpages dealing with url routing
@eSilverStrike
Copy link
Member Author

A 404 error can also happen if URL Routing is enabled and multview is enabled since this url

http://www.example.com/article/test-article

Would be redirected to http://www.example.com/article.php (thanks to multiview looking for the file) instead of http://www.example.com/index.php as it should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An issue describing unexpected or malicious behaviour.
Projects
None yet
Development

No branches or pull requests

1 participant