Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Geeklog and Plugins compatibility with PHP 7.4 and PHP 8 #1079

Closed
eSilverStrike opened this issue Dec 8, 2020 · 9 comments
Closed
Assignees
Labels
Improvement Code cleanup, Obsolete functions, or small changes to existing Features.
Milestone

Comments

@eSilverStrike
Copy link
Member

Haven't looked at 8 yet so not sure of the changes...

@eSilverStrike eSilverStrike added the Improvement Code cleanup, Obsolete functions, or small changes to existing Features. label Dec 8, 2020
@eSilverStrike eSilverStrike added this to the 2.2.2 milestone Mar 7, 2021
@eSilverStrike
Copy link
Member Author

Webservices has some PHP warnings for PHP 7.3+

See forum post: https://www.geeklog.net/forum/viewtopic.php?showtopic=97380

When I try to edit or add a new story I get the following error,

A PHP error has occurred: (This text is only displayed to users in the group 'Root') E_WARNING(2) - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? @ /home/system/lib-webservices.php line 577

@mystralkk
Copy link
Member

Webservices has some PHP warnings for PHP 7.3+

See forum post: https://www.geeklog.net/forum/viewtopic.php?showtopic=97380

When I try to edit or add a new story I get the following error,

A PHP error has occurred: (This text is only displayed to users in the group 'Root') E_WARNING(2) - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? @ /home/system/lib-webservices.php line 577

Fixed with change set e6a1e1f.

@eSilverStrike
Copy link
Member Author

We will have to check the Geeklog install, upgrade and migrate processes as well to make sure they are compatible with PHP 7.4 and 8.

An install issue that seems to deal with PHP 8 was found. See #1087

@mystralkk
Copy link
Member

mystralkk commented Jan 17, 2022

Created a new repository for plugin information: https://github.com/Geeklog-Core/Plugin-Compatibility-List . Feel free to update the list, please.

eSilverStrike added a commit that referenced this issue Jan 25, 2022
For issue #1079

 - Upgraded mlocati/ip-lib
 - Upgraded pear/pear-core-minimal
 - Upgraded phpclasses/oauth-api
 - Upgraded robthree/twofactorauth
@mystralkk
Copy link
Member

I have updated many of the plugins in https://github.com/Geeklog-Plugins to work with Geeklog 2.2.2 and PHP 8.1. Are there any other plugins we would like to have work with Geeklog 2.2.2 and PHP 8.1?

@eSilverStrike
Copy link
Member Author

Great! 👍

All the plugins I have been releasing with Geeklog should have a repository in that list.

Did you double check the forum? I can't remember if I did but I do see it is marked as Yes in the compatibility list

https://github.com/Geeklog-Core/Plugin-Compatibility-List

@mystralkk
Copy link
Member

I haven't fully checked the Forum yet with Geeklog 2.2.2 and PHP 8.1, but the plugin mostly seems to be working well. I will look into it later.

@eSilverStrike
Copy link
Member Author

It should be I was doing some work with it before I believe using PHP 8.0.

@mystralkk
Copy link
Member

I changed a few places, and the plugin is working fine with PHP 8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code cleanup, Obsolete functions, or small changes to existing Features.
Projects
None yet
Development

No branches or pull requests

2 participants