fix(): fixes willUpdate warnings (#2800)

GeekyAnts · Jul 23, 2019 · f71de0d · f71de0d
1 parent e63adfc
commit f71de0d
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 11 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -12,6 +12,7 @@
     "no-underscore-dangle": "off",
     "no-unused-expressions": "off",
     "react/jsx-filename-extension": "off",
+    "react/no-did-update-set-state": "off",
     "react/prop-types": "off"
   },
   "plugins": ["react", "jsx-a11y", "import", "react-native"]

diff --git a/src/basic/DeckSwiper.js b/src/basic/DeckSwiper.js
@@ -98,7 +98,7 @@ class DeckSwiper extends Component {
     });
   }
 
-  componentWillUpdate({ dataSource }) {
+  componentDidUpdate({ dataSource }) {
     if (dataSource.length !== this.props.dataSource.length) {
       if (dataSource.length <= 1) {
         this.setState({

diff --git a/src/basic/IconNB.js b/src/basic/IconNB.js
@@ -26,7 +26,7 @@ class IconNB extends Component {
     this.setIcon(this.props.type);
   }
 
-  componentWillUpdate(nextProps) {
+  componentDidUpdate(nextProps) {
     if (nextProps.type && this.props.type !== nextProps.type) {
       this.setIcon(nextProps.type);
     }

diff --git a/src/basic/Item.js b/src/basic/Item.js
@@ -39,7 +39,7 @@ class Item extends Component {
         this.inputProps.getRef(this._inputRef);
     }
   }
-  componentWillUpdate(nextProps) {
+  componentDidUpdate(nextProps) {
     const childrenArray = React.Children.toArray(nextProps.children);
 
     _.remove(childrenArray, item => {

diff --git a/src/basic/List.js b/src/basic/List.js
@@ -17,11 +17,7 @@ class List extends Component {
         />
       );
     }
-    return (
-      <View ref={c => (this._root = c)} {...this.props}>
-        {this.renderChildren()}
-      </View>
-    );
+    return <View ref={c => (this._root = c)} {...this.props} />;
   }
 }
 const StyledList = connectStyle('NativeBase.List', {}, mapPropsToStyleNames)(

diff --git a/src/basic/Picker.ios.js b/src/basic/Picker.ios.js
@@ -29,7 +29,7 @@ class PickerNB extends Component {
     };
   }
 
-  componentWillUpdate(nextProps) {
+  componentDidUpdate(nextProps) {
     const currentLabel = this.state.currentLabel;
     const nextLabel = this.getLabel(nextProps);
     const currentDS = this.state.dataSource;

diff --git a/src/basic/Tabs/ScrollableTabBar.js b/src/basic/Tabs/ScrollableTabBar.js
@@ -290,7 +290,7 @@ const ScrollableTabBar = createReactClass({
     );
   },
 
-  componentWillUpdate(nextProps) {
+  componentDidUpdate(nextProps) {
     // If the tabs change, force the width of the tabs container to be recalculated
     if (
       !isEqual(this.props.tabs, nextProps.tabs) &&

diff --git a/src/basic/Tabs/index.js b/src/basic/Tabs/index.js
@@ -77,7 +77,7 @@ const ScrollableTabView = createReactClass({
     InteractionManager.runAfterInteractions(scrollFn);
   },
 
-  componentWillUpdate(props) {
+  componentDidUpdate(props) {
     if (props.children !== this.props.children) {
       this.updateSceneKeys({
         page: this.state.currentPage,