Cannot access to row's index in renderRow of List

[kenji4569]

This commit a867e33#diff-adb80937e3be06283394efe72848a734
changes the behavior of the renderRow of List.
Then we can no longer access to the index of each row.
It's ok to change the behavior but we should access to the index anyway.

[kenji4569]

I could manage to access index of each row by passing "renderItem" to List as follows:

<List dataArray={items}
        {
          ...{
            renderItem: ({item, index}) => {
              return <ListItem key={index}>{'xxx'}</ListItem>
            },
          }
        }
        />

But it would be better to define renderItem explicitly to the props of List.

[kenji4569]

It might be better to keep backwards compatibility for renderRow's spec, then define a renderItem method explicitly for it.

[sankhadeeproy007]

@kenji4569 Yes, that's what has been done in the above commit. We can now access the index from renderRow as well.

[kenji4569]

@sanketsahusoft
I think previous renderRow's arguments are (rowData, secId, rowId), not (item, index), which would break the backwards compatibility.

[sankhadeeproy007]

Oh okay, does FlatList provide (rowData, secId, rowId)?
Care to send a PR with the fixes above?

[kenji4569]

does FlatList provide (rowData, secId, rowId)?

I think no.
Maybe we should set as follows:

renderItem={({ item, index }) => this.props.renderItem ? renderItem({ item, index }) : this.props.renderRow(item, 0, index)}

[kenji4569]

@PlabanJr
I think we should also fix index.d.ts for the props change.

[PlabanJr]

@PlabanJr
I think we should also fix index.d.ts for the props change.

It's done 👍