Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Add all valid props to Content interface #1908

Closed
wants to merge 1 commit into from
Closed

TS: Add all valid props to Content interface #1908

wants to merge 1 commit into from

Conversation

emily-curry
Copy link

Based on the react-native-keyboard-aware-scroll-view docs (which the Content component wraps), this component should be able to accept all ScrollView props, as well some additional props to control the keyboard-aware-scroll-view (which have been directly copied from that project's d.ts, as it does not export it's props). All redundant props have been removed from the interface.

@SupriyaKalghatgi
Copy link
Contributor

@Shurelia Can you explain me, why is contentContainerStyle and few other props excluded in your PR?

@emily-curry
Copy link
Author

Hey @SupriyaKalghatgi,
Those props are excluded because I changed Content to extend ReactNative.ScrollViewProperties. contentContainerStyle and those other excluded props are part of ScrollViewProperties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants