Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1992(tabFontSize not working) #2051

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Fix for issue #1992(tabFontSize not working) #2051

merged 1 commit into from
Jul 10, 2018

Conversation

akhil-ga
Copy link
Contributor

No description provided.

@akhil-ga akhil-ga added the PR label Jun 25, 2018
@SupriyaKalghatgi
Copy link
Contributor

#1992

@SupriyaKalghatgi SupriyaKalghatgi merged commit 263f544 into development Jul 10, 2018
@SupriyaKalghatgi SupriyaKalghatgi deleted the fix/tab/tabFontSize branch July 11, 2018 05:51
@audiolion
Copy link

This change has unfortunately made it so tabFontSize of the theme always takes precedence over any activeTextStyle or textStyle object you explicitly pass to the <Tab /> component. I feel like the order should be reversed so if you explicitly pass fontSize it should override the theme default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupriyaKalghatgi SupriyaKalghatgi Awaiting requested review from SupriyaKalghatgi

Assignees

@SupriyaKalghatgi SupriyaKalghatgi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhil-ga @SupriyaKalghatgi @audiolion