Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2825 #2827

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fixes #2825 #2827

merged 1 commit into from
Jul 31, 2019

Conversation

PlabanJr
Copy link
Contributor

No description provided.

sankhadeeproy007
sankhadeeproy007 suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@sankhadeeproy007 sankhadeeproy007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PlabanJr Just made a small request.

src/basic/List.js Outdated
@@ -11,10 +11,14 @@ class List extends Component {
if (dataArray) {
return (
<FlatList
{...this.props}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this line at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@sankhadeeproy007 sankhadeeproy007 merged commit fdc2294 into master Jul 31, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sankhadeeproy007 sankhadeeproy007 sankhadeeproy007 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlabanJr @sankhadeeproy007