Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): icons with theme not showing #2924

Closed
wants to merge 2 commits into from

Conversation

craftzdog
Copy link

this.context is always undefined in constructor method.
That causes icons not showing with theme.
Use context argument instead.

fix #2832

`this.context` is always `undefined` in `constructor` method. Refer `context` argument instead.

fix GeekyAnts#2832
@tmaly1980
Copy link

@craftzdog Can you look at why the merge is failing?

@craftzdog
Copy link
Author

There is no conflict to merge.
Tests are failing though, I guess this commit has nothing to do with them.

@tmaly1980
Copy link

Can someone look into the Travis CI system setup as to why this error is happening?

react-native: command not found

This is causing errors with the checks, and I'm guessing the failed checks is keeping someone from actually wanting to merge into master. This was submitted almost 2 weeks ago!

@rsmelo92 rsmelo92 mentioned this pull request Oct 30, 2019
6 tasks
@stale
Copy link

stale bot commented Dec 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 21, 2020
@craftzdog
Copy link
Author

why not merged? Looks like the CI issue has been solved.

@stale stale bot removed the wontfix label Dec 21, 2020
@shivrajkumar
Copy link
Collaborator

@craftzdog Can you resolve the conflicts for us to merge this

@craftzdog
Copy link
Author

@shivrajkumar Sure, done!

@craftzdog
Copy link
Author

Please merge it.

@surajahmed surajahmed deleted the branch GeekyAnts:master December 23, 2021 12:43
@surajahmed surajahmed closed this Dec 23, 2021
@surajahmed surajahmed reopened this Jan 14, 2022
@vercel
Copy link

vercel bot commented Jan 14, 2022

@craftzdog is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@stale
Copy link

stale bot commented Mar 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 16, 2022
@craftzdog craftzdog closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons not working (showing ? instead)
4 participants