-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icon): icons with theme not showing #2924
Conversation
`this.context` is always `undefined` in `constructor` method. Refer `context` argument instead. fix GeekyAnts#2832
@craftzdog Can you look at why the merge is failing? |
There is no conflict to merge. |
Can someone look into the Travis CI system setup as to why this error is happening?
This is causing errors with the checks, and I'm guessing the failed checks is keeping someone from actually wanting to merge into master. This was submitted almost 2 weeks ago! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
why not merged? Looks like the CI issue has been solved. |
@craftzdog Can you resolve the conflicts for us to merge this |
@shivrajkumar Sure, done! |
Please merge it. |
@craftzdog is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
this.context
is alwaysundefined
inconstructor
method.That causes icons not showing with theme.
Use
context
argument instead.fix #2832