Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement basic request tracing capabilities #303

Closed
fengelniederhammer opened this issue Feb 27, 2024 · 0 comments · Fixed by #304
Closed

Implement basic request tracing capabilities #303

fengelniederhammer opened this issue Feb 27, 2024 · 0 comments · Fixed by #304
Assignees
@fengelniederhammer
Labels
LAPIS Tasks/PR related to LAPIS

Comments

@fengelniederhammer
Copy link
Contributor

Related to #298, we need to be able to trace requests in the logs. We should at least be able to correlate incoming request and outgoing response.

Idea: Implement the X-Request-Id header.

  • If it is set, SILO will take the value.
  • If no value is set, SILO will generate a value
  • The response should contain the request id
  • At least one log statement should log the request ID along with some indication on the request itself
  • At least one log statement shoud log the request ID along with some indication on the response.
@fengelniederhammer fengelniederhammer added the LAPIS Tasks/PR related to LAPIS label Feb 27, 2024
@fengelniederhammer fengelniederhammer self-assigned this Feb 27, 2024
fengelniederhammer added a commit that referenced this issue Feb 27, 2024
@fengelniederhammer
feat: implement basic request id to trace requests #303
c30ca1e
@fengelniederhammer fengelniederhammer mentioned this issue Feb 27, 2024
Merged
fengelniederhammer added a commit that referenced this issue Feb 27, 2024
@fengelniederhammer
feat: implement basic request id to trace requests #303
4defb59
fengelniederhammer added a commit to GenSpectrum/LAPIS that referenced this issue Feb 27, 2024
@fengelniederhammer
feat: pass request id to SILO
77a4b7c 
See GenSpectrum/LAPIS-SILO#303
@fengelniederhammer fengelniederhammer mentioned this issue Feb 27, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Feb 27, 2024
@fengelniederhammer
refactor: don't use an exception when an if does the job #303
be649d4
@fengelniederhammer fengelniederhammer mentioned this issue Feb 27, 2024
Merged
fengelniederhammer added a commit to GenSpectrum/LAPIS that referenced this issue Feb 27, 2024
@fengelniederhammer
feat: pass request id to SILO
a7d25ed 
See GenSpectrum/LAPIS-SILO#303
fengelniederhammer added a commit that referenced this issue Feb 27, 2024
@fengelniederhammer
refactor: don't use an exception when an if does the job #303
369baba
fengelniederhammer added a commit to GenSpectrum/LAPIS that referenced this issue Feb 28, 2024
@fengelniederhammer
feat: pass request id to SILO
901e08a 
See GenSpectrum/LAPIS-SILO#303
This was referenced May 7, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Jul 9, 2024
Merged
@github-actions github-actions bot mentioned this issue Jul 22, 2024
Merged
@github-actions github-actions bot mentioned this issue Aug 6, 2024
Merged
2 tasks
@github-actions github-actions bot mentioned this issue Aug 30, 2024
Merged
This was referenced Sep 12, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Merged
@github-actions github-actions bot mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement basic request id to trace requests GenSpectrum/LAPIS-SILO
1 participant
@fengelniederhammer