Details endpoint #286
Merged
Details endpoint #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
requested review from
chaoran-chen,
Taepper,
JonasKellerer and
TobiasKampmann
fengelniederhammer
force-pushed
the
detailsEndpoint
branch
2 times, most recently
from
15e5fa2
to
30d0a7f
Compare
JonasKellerer
approved these changes
Jul 6, 2023
|
|
||
| private const val DEFAULT_MIN_PROPORTION = 0.05 | ||
| const val AGGREGATED_GROUP_BY_FIELDS_DESCRIPTION = | ||
| "The fields to stratify by. If empty, only the overall count is returned" |
There was a problem hiding this comment.
I had to look up the word stratify but it seems the right one :)
| requestContext.filter = request.sequenceFilters | ||
|
|
||
| return siloQueryModel.getDetails( | ||
| request.sequenceFilters, |
There was a problem hiding this comment.
Shouldn't this be request.sequenceFilters.filterKeys { !nonSequenceFilterFields.contains(it) }, as for aggregrated? It seems that fields is also passed as a filter?
There was a problem hiding this comment.
Or is it not necessary above?
There was a problem hiding this comment.
I checked it: It's actually not necessary, since the deserializer of the SequenceFiltersRequestWithFields takes care of that.
fengelniederhammer
force-pushed
the
detailsEndpoint
branch
from
30d0a7f
to
4171a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #283