feat: allow string arrays as filter for string and pango lineage fields #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.springframework.util.MultiValueMap | ||
|
|
||
| typealias SequenceFilters = Map<String, List<String>> | ||
| typealias GetRequestSequenceFilters = MultiValueMap<String, String> |
There was a problem hiding this comment.
Spring only properly maps GET requests if it is a MultiValueMap. Having the full MultiValueMap throughout the code was a bit too exhausting and not really necessary, because it's just a thin wrapper around Map<K, List<V>>
fengelniederhammer
force-pushed
the
507-array-input-of-string-fields-map-to-or-filter
branch
3 times, most recently
from
2cbd484
to
eddab59
Compare
lapis2/src/main/kotlin/org/genspectrum/lapis/model/SiloFilterExpressionMapper.kt
Outdated
Show resolved
Hide resolved
lapis2/src/test/kotlin/org/genspectrum/lapis/controller/LapisControllerTest.kt
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
507-array-input-of-string-fields-map-to-or-filter
branch
2 times, most recently
from
6bcc486
to
78615ed
Compare
JonasKellerer
approved these changes
Dec 19, 2023
fengelniederhammer
force-pushed
the
507-array-input-of-string-fields-map-to-or-filter
branch
from
78615ed
to
2a6e7b6
Compare
fengelniederhammer
deleted the
507-array-input-of-string-fields-map-to-or-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #507