Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement a request id to trace requests #587

Merged
merged 2 commits into from
Jan 23, 2024
Merged

feat: implement a request id to trace requests #587

merged 2 commits into from
Jan 23, 2024

Conversation

fengelniederhammer
Copy link
Contributor

resolves #586

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate end-to-end test.

@fengelniederhammer
feat: implement a request id to trace requests #586
5f6f892
@fengelniederhammer
fix: reduce log level when unable to read from cached request
467339b 
This is normal for GET requests and should not cause panic attacks when reading the logs.
@fengelniederhammer fengelniederhammer force-pushed the 586-implement-request-ids-to-trace-errors branch from 229cc24 to 467339b Compare January 22, 2024 14:55
JonasKellerer
JonasKellerer approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I only struggle with the scope. The request Id is for us very useful, but not for the enduser (which has no access to the LAPIS logs). Do we need to inform the user, that they can provide a request id? It seems they would not use that feature?

lapis2/src/main/kotlin/org/genspectrum/lapis/logging/RequestId.kt Show resolved Hide resolved
lapis2-docs/src/content/docs/concepts/request-id.mdx Show resolved Hide resolved
@JonasKellerer JonasKellerer merged commit 6810696 into main Jan 23, 2024
10 checks passed
@JonasKellerer JonasKellerer deleted the 586-implement-request-ids-to-trace-errors branch January 23, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKellerer JonasKellerer JonasKellerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement request IDs to trace errors
2 participants
@fengelniederhammer @JonasKellerer