Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use authorization filter before other filters #663

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: use authorization filter before other filters #663

merged 1 commit into from
Feb 22, 2024

Conversation

JonasKellerer
Copy link
Contributor

@JonasKellerer JonasKellerer commented Feb 22, 2024 •
edited
Loading

resolves #660

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate end-to-end test.

@JonasKellerer JonasKellerer force-pushed the 660-error-when-no-access-key-provided branch 3 times, most recently from 9e15827 to 9926c5b Compare February 22, 2024 10:51
fengelniederhammer
fengelniederhammer requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good in general!

.idea/runConfigurations/LapisV2Open.xml Outdated Show resolved Hide resolved
siloLapisTests/package.json Show resolved Hide resolved
lapis2/docker-compose.yml Show resolved Hide resolved
siloLapisTests/package.json Show resolved Hide resolved
siloLapisTests/test/protectedRoutes.spec.ts Outdated Show resolved Hide resolved
@JonasKellerer JonasKellerer force-pushed the 660-error-when-no-access-key-provided branch 7 times, most recently from e834edf to c2cda0d Compare February 22, 2024 15:04
fengelniederhammer
fengelniederhammer approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

siloLapisTests/test/lapisClientProtected/.gitignore Outdated Show resolved Hide resolved
@fengelniederhammer fengelniederhammer force-pushed the 660-error-when-no-access-key-provided branch from c2cda0d to ceb81d0 Compare February 22, 2024 15:41
@fengelniederhammer fengelniederhammer merged commit 0dab1e7 into main Feb 22, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 660-error-when-no-access-key-provided branch February 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengelniederhammer fengelniederhammer fengelniederhammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when no access key provided
2 participants
@JonasKellerer @fengelniederhammer