Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set Content-Type header to application/gzip|zstd when the compression property in the request was set #679

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

fengelniederhammer
Copy link
Contributor

resolves #665

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works in my browsers.

…ession property in the request was set #665

That way we lose information about the actual content of the request, but Chrome downloads zstd encoded data instead of failing to display it.
@fengelniederhammer fengelniederhammer merged commit 5592857 into main Feb 29, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 665-fix-compression-headers branch February 29, 2024 15:19
fengelniederhammer added a commit that referenced this pull request Feb 29, 2024
because #679 was merged without rebasing onto #677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compression headers
2 participants