Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write empty string to CSV/TSV for null values #724

Merged

Conversation

fengelniederhammer
Copy link
Contributor

resolves #708

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer force-pushed the 708-return-emptiness-instead-of-null-in-tsvcsvs branch 4 times, most recently from f161684 to c15c323 Compare April 2, 2024 13:26
@fengelniederhammer fengelniederhammer force-pushed the 708-return-emptiness-instead-of-null-in-tsvcsvs branch from c15c323 to bd37ddd Compare April 2, 2024 13:32
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengelniederhammer fengelniederhammer merged commit c8872ba into main Apr 2, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 708-return-emptiness-instead-of-null-in-tsvcsvs branch April 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return emptiness instead of null in TSV/CSVs
2 participants