Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create releases with Release Please #771

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

fengelniederhammer
Copy link
Contributor

resolves #678

#770 has been created with this.

PR Checklist

  • All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by an appropriate test.

@fengelniederhammer
Copy link
Contributor Author

Open for discussion: I implemented it such that LAPIS and the docs always get the same version. I guess that's the desired behavior?

That also implies that LAPIS gets a version bump, if we change the docs.

@chaoran-chen
Copy link
Member

That also implies that LAPIS gets a version bump, if we change the docs.

Sounds good to me!

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/release-lapis2.yml Show resolved Hide resolved
.github/workflows/release-lapis2.yml Outdated Show resolved Hide resolved
@fengelniederhammer fengelniederhammer merged commit c05f7e0 into main May 7, 2024
11 checks passed
@fengelniederhammer fengelniederhammer deleted the 678-release branch May 7, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioned releases or docker tags
3 participants