Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(root): document that regex support in LAPIS (as of 0.2.10) requires at least SILO 0.2.14 #917

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

fengelniederhammer
Copy link
Contributor

PR Checklist

  • All necessary documentation has been adapted.
    - [ ] The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lapis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 6:42am

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appart from the changelog preview.

@JonasKellerer
Copy link
Contributor

Reminder: We might need to change this after version 0.3

@fengelniederhammer
Copy link
Contributor Author

Reminder: We might need to change this after version 0.3

What do we need to change?

@JonasKellerer
Copy link
Contributor

Ah, its also higher versions. Sry.

@fengelniederhammer fengelniederhammer merged commit b2c9a94 into main Aug 27, 2024
9 checks passed
@fengelniederhammer fengelniederhammer deleted the documentRequiredVersionForRegex branch August 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants