Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): indicate error on wrong mutation filter input #156 #166

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

JonasKellerer
Copy link
Collaborator

resolves #156

Summary

Adds an error boundary on the mutation filter input, when the user enters an invalid mutation and hits enter. The indicator vanishes on typing.

Screenshot

grafik

PR Checklist

- [ ] All necessary documentation has been adapted.
- [ ] The implemented feature is covered by an appropriate test.

Copy link
Collaborator

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonasKellerer JonasKellerer merged commit b5e39c7 into main Apr 24, 2024
4 checks passed
@JonasKellerer JonasKellerer deleted the 156-mutation-filter-error-indication branch April 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation filter: error indication
2 participants