Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): use flex-grow instead of computing the tab height in JS #626

Merged
merged 2 commits into from
Jan 7, 2025
Merged

refactor(components): use flex-grow instead of computing the tab height in JS #626

merged 2 commits into from
Jan 7, 2025

Conversation

fengelniederhammer
Copy link
Collaborator

Summary

Screenshot

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the components Regarding the components label Dec 20, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 11:17am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

There is no change in the changelog. This PR will not produce a new releasable version.

JonasKellerer
JonasKellerer approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good to have this calculation removed. One minor change needs to be done, so larger elements do not escape the tab boundary, but use overflow.

components/src/preact/components/tabs.tsx Outdated Show resolved Hide resolved
components/src/preact/components/tabs.tsx Outdated Show resolved Hide resolved
components/src/preact/components/tabs.tsx Outdated Show resolved Hide resolved
@fengelniederhammer fengelniederhammer force-pushed the 624-gs-prevalence-by-location-add-download-button branch from e1958a9 to d9ad9ae Compare January 7, 2025 08:50
Base automatically changed from 624-gs-prevalence-by-location-add-download-button to main January 7, 2025 08:59
@fengelniederhammer fengelniederhammer merged commit c17b533 into main Jan 7, 2025
7 checks passed
@fengelniederhammer fengelniederhammer deleted the flexGrowInsteadofJs branch January 7, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKellerer JonasKellerer JonasKellerer approved these changes

Assignees
No one assigned
Labels
components Regarding the components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengelniederhammer @JonasKellerer