Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to evaluate should be a mandatory argument #17

Open
eudesbarbosa opened this issue Aug 19, 2021 · 1 comment · May be fixed by #22
Open

What to evaluate should be a mandatory argument #17

eudesbarbosa opened this issue Aug 19, 2021 · 1 comment · May be fixed by #22
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eudesbarbosa
Copy link

eudesbarbosa commented Aug 19, 2021

Issue
If neither --eval-meis nor --eval-dels is set the script will run without errors and without generating any output.
It is hard to debug.

# Error while running:
Rscript --vanilla /path/to/scramble/cluster_analysis/bin/SCRAMble.R \
            --out-name ...

Suggestions
Either:

  1. If neither flag is set, inform user why nothing happened and exit without any other message.
  2. Set MEI detection as default behaviour and retire the argument. I'd assume that most people would use the tool for it anyway.
@bioinfo-chru-strasbourg

+1
When the "_MEIs.txt" is generated, but without any MEIs, the VCF file seems to not be generated :

Done analyzing MEIs
Writing VCF file to /tmp/scramble/sample.vcf...
Error in order(...) : argument 1 is not a vector
Calls: [ ... order -> standardGeneric -> eval -> eval -> eval -> order
Execution halted

Suggestion :
Generate an valid empty VCF

@rebeccaito rebeccaito self-assigned this Feb 11, 2022
@rebeccaito rebeccaito added the bug Something isn't working label Feb 11, 2022
@rebeccaito rebeccaito added this to the 2022.0 milestone Feb 11, 2022
@rebeccaito rebeccaito linked a pull request Feb 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants