Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification List Styling #88

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Notification List Styling #88

merged 6 commits into from
Apr 19, 2024

Conversation

andrewcaplan1
Copy link
Contributor

styling

Description

[Link to Ticket](insert the link to your ticket inside the parenthesis here)

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@andrewcaplan1 andrewcaplan1 requested review from MattCMcCoy and CaitlinFlynn and removed request for MattCMcCoy and CaitlinFlynn April 18, 2024 18:38
@MattCMcCoy
Copy link
Contributor

@andrewcaplan1 we are revisiting this after showcase right?

@MattCMcCoy
Copy link
Contributor

MattCMcCoy commented Apr 18, 2024

Screenshot 2024-04-18 at 5 10 16 PM Warning message when switching to screen

fix warning from duplicate navigation names
@andrewcaplan1 andrewcaplan1 requested review from MattCMcCoy and removed request for CaitlinFlynn April 19, 2024 17:37
Copy link
Contributor

@MattCMcCoy MattCMcCoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After showcase everything dealing with time should be changed to use moment

@MattCMcCoy MattCMcCoy merged commit fdb697a into main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants