Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual input form #50

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Update manual input form #50

merged 2 commits into from
Apr 16, 2024

Conversation

aaronkim218
Copy link
Contributor

@aaronkim218 aaronkim218 commented Mar 31, 2024

Description

Removed bend extrusion field from manual input form. Send data from manual input form to manua_input_to_gcode executable as json string. im using nlohmann/json library to parse the json string. i included it in the project as a single header file under a new directory "backend/dependencies". i also changed the bend direction input field from a number to a string because manual_input_to_gcode expects bend direction to be something like "y+"

Fixes #42 and #46

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
If they are unit tests, provide the file name the tests are in.
If they are not unit tests, describe how you tested the change.

Checklist:

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@aaronkim218 aaronkim218 changed the title remove extrusion field and connect form to manual input executable Update manual input form Apr 1, 2024
@muneerlalji muneerlalji merged commit f49ea13 into main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending Manual Input Form to Backend
2 participants