Add dev message for binarySearch bounds #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asselstine
requested changes
Aug 18, 2023
src/libraries/DrawAccumulatorLib.sol
Outdated
| @@ -409,6 +409,7 @@ library DrawAccumulatorLib { | |||
| } | |||
|
|
|||
| /// @notice Binary searches an array of draw ids for the given target draw id. | |||
| /// @dev Index bounds and draw ID bounds must be validated before they are passed to this function. | |||
There was a problem hiding this comment.
Would be more specific here: "the target draw id must be on or with the oldest draw id and newest draw id"
asselstine
approved these changes
Aug 18, 2023
asselstine
deleted the
gen-193-c4-issue-445-draw-accumulater-binary-search-exit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses c4-issue-445: code-423n4/2023-07-pooltogether-findings#445
Summary
When used in the intended context, the binarySearch function always has a valid exit condition. Instead of adding an additional, unreachable exit condition, the intended context has been added as a dev comment on the function.