Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery in the documentation mixes classic and modern #1412

Closed
PaulWessel opened this issue Aug 19, 2019 · 7 comments
Closed

Gallery in the documentation mixes classic and modern #1412

PaulWessel opened this issue Aug 19, 2019 · 7 comments

Comments

@PaulWessel
Copy link
Member

Description of the problem

The 50 GMT examples in the gallery shows classic mode while the 8 animation examples are modern. Since we have separate documentation and tutorials for classic and modern we should probably have separate classic and modern mode galleries, where the classic simply won't have any animations. We can probably finish the remaining non-modern examples before the release. Thoughts?

@seisman
Copy link
Member

seisman commented Aug 19, 2019

we have separate documentation and tutorials for classic and modern

I remember we decided to remove classic tutorial and cookbook from the repository and let classic-mode users to read the 5.4 documentations. I think we can do the same thing to the gallery.

@PaulWessel
Copy link
Member Author

OK, then we need to convert examples 37, 38, 40, 45 to modern mode (test/exmod). I think I saved those because there is more work then many of the others or they are inherently very classic. Feel free to have a look. Going out for a few hours - cannot avoid the beach the entire workation.

@seisman
Copy link
Member

seisman commented Aug 20, 2019

I've finished ex40 and ex45, but not sure what's the best way to convert ex37 and ex38.

@seisman
Copy link
Member

seisman commented Aug 28, 2019

Now we have all the 50 modern examples ready.

@seisman
Copy link
Member

seisman commented Aug 29, 2019

Are we going to replace the classic examples with the modern ones now? The only issue is the Windows batch scripts, which are still in classic mode.

@PaulWessel
Copy link
Member Author

They have not changed since 5.4 I think so anyone foolish enough to want to write BAT files can go there.

@PaulWessel
Copy link
Member Author

So yes, I think we should show modern mode scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants