Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relpace classic gallery scripts with modern mode #851

Closed
PaulWessel opened this issue Jun 6, 2019 · 4 comments
Closed

Relpace classic gallery scripts with modern mode #851

PaulWessel opened this issue Jun 6, 2019 · 4 comments
Milestone

Comments

@PaulWessel
Copy link
Member

Let the gallery use modern mode

With the push to modern mode it makes sense to simplify our gallery by using modern mode as well. Right now, only 13 of the 50 scripts have a modern mode equivalent in test/exmod. Perhaps we should make a push to convert the rest in test/exmod first and then we can switch classic and modern when ready?

@seisman seisman added this to the 6.0.0b1 milestone Jun 7, 2019
@PaulWessel
Copy link
Member Author

Thanks, just add in test/exmod for now. To avoid us both doing the same, how about you start on the lower half (1-25) and I start 26-50?

@seisman
Copy link
Member

seisman commented Jun 7, 2019

OK.

@seisman
Copy link
Member

seisman commented Jun 12, 2019

@PaulWessel I think we should NOT add the modern examples to test/exmod.

The examples are pretty large (~40 Mb). Converting these examples to modern mode and adding them to test/exmod means adding another 40 Mb to the repository.

Although the classic examples will be deleted someday, the 40 Mb files always stay somewhere in the git history. Currently, the repository size is as large as 700 Mb, and the .git directory is almost 500 Mb.

We should try our best to avoid adding more large files to the git history.

@seisman seisman modified the milestones: 6.0.0b1, 6.0.0 Jun 14, 2019
@seisman
Copy link
Member

seisman commented Aug 28, 2019

Duplicate of #1412. Closed.

@seisman seisman closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants