Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions to running and adding tests in CONTRIBUTING.md #364

Closed
leouieda opened this issue Jan 24, 2019 · 1 comment · Fixed by #5991
Closed

Instructions to running and adding tests in CONTRIBUTING.md #364

leouieda opened this issue Jan 24, 2019 · 1 comment · Fixed by #5991
Assignees
@maxrjones
Labels
documentation Improve documentation longterm Long standing issues that need to be resolved

Comments

@leouieda
Copy link
Member

Description of the desired feature

There need to be instructions for running the tests (what commands, what needs to be installed, how it works) so potential devs can check that they didn't break anything. There also need to be instruction for adding a new test including guidelines on what makes a good test (minimal, test only one thing, don't test the same thing that other tests already cover, etc).
@stale
Copy link

stale bot commented Feb 23, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@stale stale bot added the stale This will not be worked on label Feb 23, 2019
@leouieda leouieda added longterm Long standing issues that need to be resolved and removed stale This will not be worked on labels Feb 25, 2019
@maxrjones maxrjones added the documentation Improve documentation label Feb 23, 2021
@maxrjones maxrjones mentioned this issue Feb 23, 2021
Closed
obaney pushed a commit to obaney/gmt that referenced this issue Aug 18, 2021
@seisman
Mark xarray shading test fail for GMT<=6.1.1 (GenericMappingTools#649)
a6a0919 
The xarray shading issue in GenericMappingTools#364 was fixed by upstream GMT in GenericMappingTools#4328.

This PR updates the pytest xfail condition so that the xarray shading test is expected to xfail only for GMT<=6.1.1.
@maxrjones maxrjones mentioned this issue Oct 19, 2021
Merged
4 tasks
@maxrjones maxrjones self-assigned this Oct 19, 2021
@maxrjones maxrjones mentioned this issue Nov 12, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxrjones maxrjones

Labels
documentation Improve documentation longterm Long standing issues that need to be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more instructions to the contributing guide GenericMappingTools/gmt
2 participants
@leouieda @maxrjones