Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if dims, range, and inc are all not given properly #5772

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR adds an error if an equidistant vector arrangement is not given and dim is also not provided. While I am confident this is the right place to raise an error for the case from GenericMappingTools/pygmt#1483, it would be good to get feedback about whether this is the proper error to raise out of the options in GMT_api_error_code.

Fixes GenericMappingTools/pygmt#1483

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that should do it.

@maxrjones maxrjones merged commit f5c3c79 into master Sep 16, 2021
@maxrjones maxrjones deleted the update-gmtapi_init_matrix branch September 16, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault if a grid has zero increments
2 participants