Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update psconvert to handle gs version 10 #7096

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Update psconvert to handle gs version 10 #7096

merged 3 commits into from
Nov 18, 2022

Conversation

PaulWessel
Copy link
Member

We had specific tests that did not anticipate a gs version 10 and hence turned off transparency flags. This PR addresses this and isolates the checks in a bool function that we can update as specific future gs versions have trouble. So this time it was not gs that was the culprit but us.

We had specific tests that did not anticipate a gs version 10 and hence turned off transparency flags.  This PR addresses this and isolates the checks in a bool function that we can update as specific future gs versions have trouble.
@PaulWessel PaulWessel added the bug Something isn't working label Nov 18, 2022
@PaulWessel PaulWessel added this to the 6.5.0 milestone Nov 18, 2022
@PaulWessel PaulWessel self-assigned this Nov 18, 2022
@Esteban82
Copy link
Member

Is there any test?

@PaulWessel
Copy link
Member Author

You will need access to gs 10 and then try to make a transparent PDF or PNG using -G/path/to/gs10 in psconvert. So no test can be added here.

@PaulWessel
Copy link
Member Author

You can make a PS file for testing this way:

echo 0 0 | gmt psxy -R-2/2/-2/2 -JX10c -B0 -Sc5c -Gred@50 -P > t.ps

Then gs 9 (my default) gives correct transparency:

gmt psconvert t.ps -Tf

If I build gs 10 and us it:

gmt psconvert t.ps -Tf -G/Users/pwessel/Downloads/ghostscript-10.0.0/bin/gs

then master fails while this branch works.

Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite having no gs 10 installed to test it, given the nature of the bug, if it works in one OS there is no reason to not work in all the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants