Do no free external trailing text strings #7557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See GenericMappingTools/pygmt#2524 for background. Sees we are trying to free strings thar belong to Python and not GMT. However, not solved yet.
joa-quim
reviewed
Jun 19, 2023
src/gmt_io.c
Outdated
| gmt_M_str_free (S->text[row]); | ||
| gmt_M_free (GMT, S->text); | ||
| if (S->text == NULL) return; /* No trailing text array */ | ||
| if (SH->alloc_mode_text == GMT_ALLOC_INTERNALLY) { /* We can free these strings */ |
seisman
reviewed
Jun 19, 2023
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
PaulWessel
changed the title
seisman
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GenericMappingTools/pygmt#2524 for background. Sees we are trying to free strings thar belong to Python and not GMT. However, not solved yet.
@seisman if you see other places in the code where we need to do something like here, let me know. I see we have a VECTOR hidden flag for
VH->alloc_mode_textand now we added a per segmentSH->alloc_mode_text. Suspect there is still some lack of communication between vector and segment internally that is missing.Will return to this later but feel tree to try it. It still have me the same messages.