Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psconvert should ignore writing world file if geotiff output is requested #7865

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

PaulWessel
Copy link
Member

See #7844 for discussion. Closes #7844. Note to @joa-quim : In messages that says

...the Proj4 command...

should that be PROJ or are these things still called Proj4 even though we are at Proj9? Let me know if we should update such language in source and rst (separate from this PR). I just added an extra check that we only do the world_file output if Ctrl->W.warp (-W+g) is not set. See right, no?

See #7844 for discussion.  Closes #7844. Note to @joa-quim : In messages that says

...the Proj4 command...

should that be PROJ or are these things still called proj4 even though we are at proj9?
@PaulWessel PaulWessel added the bug Something isn't working label Oct 4, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 4, 2023
@PaulWessel PaulWessel requested review from joa-quim and seisman October 4, 2023 09:21
@PaulWessel PaulWessel self-assigned this Oct 4, 2023
@joa-quim
Copy link
Member

joa-quim commented Oct 4, 2023

Does it work? Because when it calls gdal_translate it's not impossible that a world fine is needed.

The Proj4 vs PROJ. There is only proj4 , the name, or PROJ (and don't pay attention to the capitalization. I don't know what is the correct way). No proj5,6,7,8,9. Functions variables, including in official PostGIS docs are still called proj4... The guys that took care of proj development decided to drop the 4 from the name at around proj v6, but there are still tons of proj4 references in the internet. So, in summary, for my taste, I still prefer to call the proj4 strings as is still used in, for example,
https://spatialreference.org/ref/epsg/4326/

@seisman
Copy link
Member

seisman commented Oct 4, 2023

Does it work? Because when it calls gdal_translate it's not impossible that a world fine is needed.

You're right. It needs the world file to produce the GeoTIFF file. It means we need to delete the world file after calling gdal_translate.

@PaulWessel
Copy link
Member Author

OK, I will fix that. Will leave proj4 of course.

Keep old world_file name so it can be deleted.
@PaulWessel
Copy link
Member Author

How about this one? Had to duplicate world_file since you recycled it for something else and it got lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect world file name when generating GeoTIFF file
3 participants